Tandem/certspotter
2
0
Fork 0
mirror of https://github.com/SSLMate/certspotter.git synced 2025-07-03 10:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid inclusive end bound until last possible moment

Browse Source 
Inclusive end bounds are the devil.
This commit is contained in:
Andrew Ayer 2025-05-06 14:52:15 -04:00
parent 8119925c16
commit a6af6c54ba
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
monitor/monitor.go
View File

@ -83,10 +83,10 @@ func withRetry(ctx context.Context, maxRetries int, f func() error) error {
return ctx.Err()
}
func getEntriesFull(ctx context.Context, client ctclient.Log, startInclusive, endInclusive uint64) ([]ctclient.Entry, error) {
allEntries := make([]ctclient.Entry, 0, endInclusive-startInclusive+1)
for startInclusive <= endInclusive {
entries, err := client.GetEntries(ctx, startInclusive, endInclusive)
func getEntriesFull(ctx context.Context, client ctclient.Log, startInclusive, endExclusive uint64) ([]ctclient.Entry, error) {
allEntries := make([]ctclient.Entry, 0, endExclusive-startInclusive)
for startInclusive < endExclusive {
entries, err := client.GetEntries(ctx, startInclusive, endExclusive-1)
if err != nil {
return nil, err
}
@ -418,7 +418,7 @@ func downloadWorker(ctx context.Context, config *Config, ctlog *loglist.Log, cli
case batch = <-batchesIn:
}
entries, err := getEntriesFull(ctx, client, batch.begin, batch.end-1)
entries, err := getEntriesFull(ctx, client, batch.begin, batch.end)
if err != nil {
return err
}