From a8654606c2636824c9e8ac3f0cfd1bf944c8eb24 Mon Sep 17 00:00:00 2001
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Fri, 18 May 2018 19:51:33 +0200
Subject: [PATCH] wg: fix errno propagation and messages

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 src/ipc.c      | 3 +--
 src/set.c      | 2 +-
 src/setconf.c  | 2 +-
 src/show.c     | 8 ++++----
 src/showconf.c | 2 +-
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/ipc.c b/src/ipc.c
index 3f23d1d..cdb152b 100644
--- a/src/ipc.c
+++ b/src/ipc.c
@@ -185,7 +185,7 @@ static int userspace_get_wireguard_interfaces(struct inflatable_buffer *buffer)
 
 	dir = opendir(SOCK_PATH);
 	if (!dir)
-		return errno == ENOENT ? 0 : errno;
+		return errno == ENOENT ? 0 : -errno;
 	while ((ent = readdir(dir))) {
 		len = strlen(ent->d_name);
 		if (len <= strlen(SOCK_SUFFIX))
@@ -964,7 +964,6 @@ char *ipc_list_devices(void)
 cleanup:
 	errno = -ret;
 	if (errno) {
-		perror("Error when trying to get a list of WireGuard interfaces");
 		free(buffer.buffer);
 		return NULL;
 	}
diff --git a/src/set.c b/src/set.c
index b3f57ef..d44fed9 100644
--- a/src/set.c
+++ b/src/set.c
@@ -29,7 +29,7 @@ int set_main(int argc, char *argv[])
 	device->name[IFNAMSIZ - 1] = '\0';
 
 	if (ipc_set_device(device) != 0) {
-		perror("Unable to set device");
+		perror("Unable to modify interface");
 		goto cleanup;
 	}
 
diff --git a/src/setconf.c b/src/setconf.c
index f146a48..012c245 100644
--- a/src/setconf.c
+++ b/src/setconf.c
@@ -51,7 +51,7 @@ int setconf_main(int argc, char *argv[])
 	device->name[IFNAMSIZ - 1] = '\0';
 
 	if (ipc_set_device(device) != 0) {
-		perror("Unable to set device");
+		perror("Unable to modify interface");
 		goto cleanup;
 	}
 
diff --git a/src/show.c b/src/show.c
index 3fd6a67..1b8712f 100644
--- a/src/show.c
+++ b/src/show.c
@@ -390,7 +390,7 @@ int show_main(int argc, char *argv[])
 		char *interfaces = ipc_list_devices(), *interface;
 
 		if (!interfaces) {
-			perror("Unable to get devices");
+			perror("Unable to list interfaces");
 			return 1;
 		}
 		interface = interfaces;
@@ -398,7 +398,7 @@ int show_main(int argc, char *argv[])
 			struct wgdevice *device = NULL;
 
 			if (ipc_get_device(&device, interface) < 0) {
-				perror("Unable to get device");
+				perror("Unable to access interface");
 				continue;
 			}
 			if (argc == 3) {
@@ -424,7 +424,7 @@ int show_main(int argc, char *argv[])
 		}
 		interfaces = ipc_list_devices();
 		if (!interfaces) {
-			perror("Unable to get devices");
+			perror("Unable to list interfaces");
 			return 1;
 		}
 		interface = interfaces;
@@ -437,7 +437,7 @@ int show_main(int argc, char *argv[])
 		struct wgdevice *device = NULL;
 
 		if (ipc_get_device(&device, argv[1]) < 0) {
-			perror("Unable to get device");
+			perror("Unable to access interface");
 			return 1;
 		}
 		if (argc == 3) {
diff --git a/src/showconf.c b/src/showconf.c
index fa3fd2d..390273a 100644
--- a/src/showconf.c
+++ b/src/showconf.c
@@ -32,7 +32,7 @@ int showconf_main(int argc, char *argv[])
 	}
 
 	if (ipc_get_device(&device, argv[1])) {
-		perror("Unable to get device");
+		perror("Unable to access interface");
 		goto cleanup;
 	}