takino
/
termite
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix off-by-one in select_text() on libvte >= 0.55.0 

Version 0.55.0 rewrote the selection bounds and made them non-inclusive
of the end-position. Take this into consideration.
This commit is contained in:
Warepire 2019-05-09 23:16:16 +02:00
parent 4aa842245f
commit 7e9a93b421
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
termite.cc
View File

@ -441,7 +441,7 @@ static void update_selection(VteTerminal *vte, const select_info *select) {
} }
const long n_columns = vte_terminal_get_column_count(vte); const long n_columns = vte_terminal_get_column_count(vte);
long cursor_col, cursor_row; long cursor_col, cursor_row, selection_x_end;
vte_terminal_get_cursor_position(vte, &cursor_col, &cursor_row); vte_terminal_get_cursor_position(vte, &cursor_col, &cursor_row);
vte_terminal_set_selection_block_mode(vte, select->mode == vi_mode::visual_block); vte_terminal_set_selection_block_mode(vte, select->mode == vi_mode::visual_block);
@ -450,22 +450,38 @@ static void update_selection(VteTerminal *vte, const select_info *select) {
const long begin = select->begin_row * n_columns + select->begin_col; const long begin = select->begin_row * n_columns + select->begin_col;
const long end = cursor_row * n_columns + cursor_col; const long end = cursor_row * n_columns + cursor_col;
if (begin < end) { if (begin < end) {
selection_x_end = cursor_col;
#if VTE_CHECK_VERSION(0, 55, 0)
selection_x_end += 1;
#endif
vte_terminal_select_text(vte, select->begin_col, select->begin_row, vte_terminal_select_text(vte, select->begin_col, select->begin_row,
cursor_col, cursor_row); selection_x_end, cursor_row);
} else { } else {
selection_x_end = select->begin_col;
#if VTE_CHECK_VERSION(0, 55, 0)
selection_x_end += 1;
#endif
vte_terminal_select_text(vte, cursor_col, cursor_row, vte_terminal_select_text(vte, cursor_col, cursor_row,
select->begin_col, select->begin_row); selection_x_end, select->begin_row);
} }
} else if (select->mode == vi_mode::visual_line) { } else if (select->mode == vi_mode::visual_line) {
selection_x_end = n_columns - 1;
#if VTE_CHECK_VERSION(0, 55, 0)
selection_x_end += 1;
#endif
vte_terminal_select_text(vte, 0, vte_terminal_select_text(vte, 0,
std::min(select->begin_row, cursor_row), std::min(select->begin_row, cursor_row),
n_columns - 1, selection_x_end,
std::max(select->begin_row, cursor_row)); std::max(select->begin_row, cursor_row));
} else if (select->mode == vi_mode::visual_block) { } else if (select->mode == vi_mode::visual_block) {
selection_x_end = std::max(select->begin_col, cursor_col);
#if VTE_CHECK_VERSION(0, 55, 0)
selection_x_end += 1;
#endif
vte_terminal_select_text(vte, vte_terminal_select_text(vte,
std::min(select->begin_col, cursor_col), std::min(select->begin_col, cursor_col),
std::min(select->begin_row, cursor_row), std::min(select->begin_row, cursor_row),
std::max(select->begin_col, cursor_col), selection_x_end,
std::max(select->begin_row, cursor_row)); std::max(select->begin_row, cursor_row));
} }